-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Page Template picker if modal layout picker is available #2478
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
The iOS PR is still in design review but this can be reviewed and merged separately from that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#23872 (review)
There seems to be a sync issue here as the PR isn't showing the merge commit. Closing and reopening |
Fixes: #2419
Related PRs:
gutenberg
: Disable Page Template picker if modal layout picker is available WordPress/gutenberg#23872WordPress-iOS
: Create Modal Layout Picker Container for new Gutenberg pages and feature flag for development WordPress-iOS#14456Description
This change enables the mobile editor to accept the capability
modalLayoutPicker
and based on that conditionally show or hide the Template Picker.Opening this PR to generate a bundle so that the toggle in iOS is testable.
How has this been tested?
To disable or enable the development version of Modal Layout Picker
To toggle:
On iOS using the build options mentioned above
With Gutenberg Modal Layout Picker toggled on:
With Gutenberg Modal Layout Picker toggled on:
With Gutenberg Modal Layout Picker toggled off:
With Gutenberg Modal Layout Picker toggled off:
With Gutenberg Modal Layout Picker toggled on or off:
On Android running a metro server or generating a build
PR submission checklist:
[RELEASE-NOTES.txt](RELEASE-NOTES.txt)
if necessary.